I said no such thing, modern SONAR is extremely effective, it just doesn't make a ping noise anymore!
A submarine's effective torpedo range is determined by 2 factors, the actual range of the torpedo and the submarine's ability to form a firing solution. Generally a submarine has much more capable SONAR than surface ships as it's their only eyes (ears?) and so their ability to detect and track ships at distance is better. Added to that, submarine's can hide in isothermal layers in the sea which refract sound waves and confuse shipbourne SONAR, the submarine of course knows the isotherm is there and so can compensate for it.
Surface ships have hull mounted active SONAR to deter and as a last resort detect submarines, if they wanted to track a sub at distance then using a towed array passive SONAR is the best bet, but it's awkward and very difficult to get a firing solution using passive alone. Added to that, the torpedos fitted to ships are very short range and just for counter fire really.
Submarine launched anti air missiles have been invented but they require the submarine to come up to a certain depth to launch which of course makes detection much more likely, generally if a submarine is being prosecuted by air assets they'll run and hide rather than attempt to fight. Also, the second a missile breaks the water everyone knows exactly where the submarine is so can just drop a torpedo on that spot and be almost guaranteed to ruin their day.
